Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... Patch Set 4: (5 comments) Thank you for catching those! http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h@42 PS2, Line 42: > define as inline function Done http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h@44 PS2, Line 44: inline int ThriftDefaultMaxMessageSize() { > add a comment for this function Done http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp File be/src/transport/TSaslTransport.cpp: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp@43 PS2, Line 43: TMemoryBuffer(DEFAULT_MEM_BUF_SIZE > should we set DefaultTConfiguration() for this TMemoryBuffer? Done http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp@53 PS2, Line 53: TMemoryBuffer(i > same comment as last one. Done http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/util/parquet-reader.cc@75 PS2, Line 75: memory trans > Should we set TConfiguration? Done -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 16:22:48 +0000 Gerrit-HasComments: Yes
