Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19179/4/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/19179/4/be/src/rpc/thrift-util.h@49 PS4, Line 49: /// Return the default Thrift's TConfi > Looks like inlining ThriftRpcMaxMessageSize makes clang-tidy unhappy. I'll How about to add a header file thrift-util.inline.h and move the inline function definitions to new header file? -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 17:23:30 +0000 Gerrit-HasComments: Yes
