Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 )
Change subject: IMPALA-9488: Add metrics for EC reads ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/19178/12/tests/query_test/test_io_metrics.py File tests/query_test/test_io_metrics.py: http://gerrit.cloudera.org:8080/#/c/19178/12/tests/query_test/test_io_metrics.py@53 PS12, Line 53: append_metric("impala-server.io-mgr.local-bytes-read", IS_HDFS) Also needs to be negative for dockerized and out-of-cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/19178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb06bac9dea4b632621653d2935e9a7b2dc81341 Gerrit-Change-Number: 19178 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 14:43:32 +0000 Gerrit-HasComments: Yes
