Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19178 )
Change subject: IMPALA-9488: Add metrics for EC reads ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/19178/13/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/19178/13/be/src/exec/hdfs-scan-node-base.h@94 PS13, Line 94: /// Whether file is erasure coded. : bool is_erasure_coded = false; > Should we add the bool member at the end of the member list? So if later we I had that in mind putting it here, but wouldn't hurt to move it further down. All values seem to be before the typedefs. http://gerrit.cloudera.org:8080/#/c/19178/13/tests/query_test/test_io_metrics.py File tests/query_test/test_io_metrics.py: http://gerrit.cloudera.org:8080/#/c/19178/13/tests/query_test/test_io_metrics.py@62 PS13, Line 62: expected_bytes_delta = 2199 > nit: maybe add comment: Length of text file 'nation.tbl' Ack -- To view, visit http://gerrit.cloudera.org:8080/19178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb06bac9dea4b632621653d2935e9a7b2dc81341 Gerrit-Change-Number: 19178 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 17:50:07 +0000 Gerrit-HasComments: Yes
