Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 )
Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs ...................................................................... Patch Set 6: (3 comments) This patch looks pretty good to me! Is it possible to add tests on Hive's builtin GenericUDFs, e.g. mask(), corr()? The later one is a GenericUDAF. http://gerrit.cloudera.org:8080/#/c/19177/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19177/6//COMMIT_MSG@22 PS6, Line 22: In this case initialize() will be called during : analyses of the query with the expected argument types. Do we have tests on analysis errors in this step? http://gerrit.cloudera.org:8080/#/c/19177/6/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19177/6/tests/query_test/test_udfs.py@348 PS6, Line 348: load-persistent-generic-java-udfs This file is missing http://gerrit.cloudera.org:8080/#/c/19177/6/tests/query_test/test_udfs.py@349 PS6, Line 349: generic-java-udf It's run in the above test. Any reason to run it again here? -- To view, visit http://gerrit.cloudera.org:8080/19177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d402784fa91d1256f5d57fa16ac49728447c8 Gerrit-Change-Number: 19177 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Nov 2022 08:28:18 +0000 Gerrit-HasComments: Yes
