Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 )
Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/catalog/Function.java File fe/src/main/java/org/apache/impala/catalog/Function.java: http://gerrit.cloudera.org:8080/#/c/19177/6/fe/src/main/java/org/apache/impala/catalog/Function.java@186 PS6, Line 186: getSymbolName Why do we need to include this in this class as opposed to ScalarFunction? -- To view, visit http://gerrit.cloudera.org:8080/19177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d402784fa91d1256f5d57fa16ac49728447c8 Gerrit-Change-Number: 19177 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Dec 2022 13:34:50 +0000 Gerrit-HasComments: Yes
