Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 13: -Code-Review > Just a minor question, FALLBACK_DB_FOR_FUNCTIONS brings flexibility > to FUNCTION calls, but it breaks the isolation between different > databases, we can still use the Apache Ranger for authorization of > those FUNCTIONs to implement the isolation, right? Has this been > tested? That is a very good point, Impala should not allow using functions in the fallback database unless the user has some privileges on the given database. Note that there is an open review related to the authorization of UDFs: https://gerrit.cloudera.org/#/c/19194/ An example authorization test which deals with UDF + sets a query option: https://github.com/apache/impala/blob/52956bae141acf2ecdd7b28ff7edb4d2f2fe3f10/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java#L2932 Note that the AuthorizationStmtTest test suite can be extremely slow to run. -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 13 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 14:37:14 +0000 Gerrit-HasComments: No
