Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 )
Change subject: IMPALA-11728: Set fallback database for functions ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/19252/15/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19252/15/tests/authorization/test_ranger.py@1146 PS15, Line 1146: result = self.execute_query_expect_failure( : non_owner_client, "select identity(1)", query_options={ : 'FALLBACK_DB_FOR_FUNCTIONS': unique_database}, user=test_user) : err = "User '{0}' does not have privileges to access: {1}".format( : test_user, unique_database) : assert err in str(result) Can you check what error is returned if look for a function that does not exist in fallback db? Generally we should not be able to decide based on the error message whether something (e.g. table, function) exists or not if the user has no privileges on it at all (this why an auth error is returned in line 1132. http://gerrit.cloudera.org:8080/#/c/19252/15/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19252/15/tests/query_test/test_udfs.py@674 PS15, Line 674: Can you also add a test for show function? It should return empty result, even when FALLBACK_DB_FOR_FUNCTIONS is set and is not empty. -- To view, visit http://gerrit.cloudera.org:8080/19252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b7e126718fea1c50723cacbaed898b20bb55e5 Gerrit-Change-Number: 19252 Gerrit-PatchSet: 15 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 14:21:33 +0000 Gerrit-HasComments: Yes
