Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 )
Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19290/1/tests/custom_cluster/test_reserved_words_version.py File tests/custom_cluster/test_reserved_words_version.py: http://gerrit.cloudera.org:8080/#/c/19290/1/tests/custom_cluster/test_reserved_words_version.py@27 PS1, Line 27: assert "A reserved word cannot be used here: at" in \ Just an optional idea: most queries in test_3_0() and test_2_11() are the same, we could extract the common subset to a separate helper function. -- To view, visit http://gerrit.cloudera.org:8080/19290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9605d80a25ff878d12f6ca2ebb99ac26298d8efa Gerrit-Change-Number: 19290 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 13:25:55 +0000 Gerrit-HasComments: Yes