Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 )
Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/19290/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/19290/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3575 PS8, Line 3575: "Hint: reserved words have to be escaped when used as an identifier, e.g. `from`\n" line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19290/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3588 PS8, Line 3588: "Hint: reserved words have to be escaped when used as an identifier, e.g. `where`\n" line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19290/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3599 PS8, Line 3599: "Hint: reserved words have to be escaped when used as an identifier, e.g. `where`\n" line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19290/8/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3622 PS8, Line 3622: "Hint: reserved words have to be escaped when used as an identifier, e.g. `group`\n" line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19290/8/tests/custom_cluster/test_reserved_words_version.py File tests/custom_cluster/test_reserved_words_version.py: http://gerrit.cloudera.org:8080/#/c/19290/8/tests/custom_cluster/test_reserved_words_version.py@28 PS8, Line 28: e flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19290/8/tests/custom_cluster/test_reserved_words_version.py@36 PS8, Line 36: flake8: E501 line too long (95 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/19290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9605d80a25ff878d12f6ca2ebb99ac26298d8efa Gerrit-Change-Number: 19290 Gerrit-PatchSet: 8 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 10:47:37 +0000 Gerrit-HasComments: Yes
