Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19291
Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned ...................................................................... IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned The following code in buildBinaryStatsPredicate has a potential bug: // Obtain the rhs expr of the input predicate Expr constExpr = inputPred.getChild(1); ... BinaryPredicate statsPred = new BinaryPredicate(op, slot, constExpr); The constExpr is mutable and the "new BinaryPredicate" can change the object. If it does, it could have an adverse effect on inputPred. Change-Id: I959f1ded63baba884391cbf23d7e59316838c8ef --- M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19291/1 -- To view, visit http://gerrit.cloudera.org:8080/19291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I959f1ded63baba884391cbf23d7e59316838c8ef Gerrit-Change-Number: 19291 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <scar...@cloudera.com>