Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 )
Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned ...................................................................... Patch Set 1: Code-Review+2 We should file a ticket to review CNF rewrites and other places we might be passing expressions without cloning them. A quick review of calls to 'new BinaryPredicate' looks somewhat inconsistent. This change seems safe and necessary however. -- To view, visit http://gerrit.cloudera.org:8080/19291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I959f1ded63baba884391cbf23d7e59316838c8ef Gerrit-Change-Number: 19291 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Dec 2022 17:32:55 +0000 Gerrit-HasComments: No
