Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 15: Code-Review+1 (8 comments) Just a few nits. I think this makes sense. It's a substantial change and a lot of reviewers have been involved; I'd like to see a majority of active reviewers +1 it before I'm ready to +2. http://gerrit.cloudera.org:8080/#/c/19181/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19181/15//COMMIT_MSG@17 PS15, Line 17: singlton typo: singleton http://gerrit.cloudera.org:8080/#/c/19181/15/be/src/codegen/llvm-codegen-cache.h File be/src/codegen/llvm-codegen-cache.h: http://gerrit.cloudera.org:8080/#/c/19181/15/be/src/codegen/llvm-codegen-cache.h@106 PS15, Line 106: static const size_t OptimalKeySize = sizeof(HashCode) + sizeof(ElementLengthType); nit: this could be a (compile-time) constexpr. http://gerrit.cloudera.org:8080/#/c/19181/12/be/src/codegen/llvm-codegen-cache.h File be/src/codegen/llvm-codegen-cache.h: http://gerrit.cloudera.org:8080/#/c/19181/12/be/src/codegen/llvm-codegen-cache.h@30 PS12, Line 30: #include "thirdparty/datasketches/MurmurHash3.h" > Header thirdparty/datasketches/MurmurHash3.h is needed by the struct HashSt Ack http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py File tests/custom_cluster/test_codegen_cache.py: http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@71 PS12, Line 71: "select * from functional.alltypes where bigint_col > 0") > Done Done http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@77 PS12, Line 77: "select * from functional.alltypes where float_col > 0") > Done Done http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@83 PS12, Line 83: "select * from functional.alltypes where double_col > 0") > Done Done http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@89 PS12, Line 89: "select * from functional.alltypes where date_string_col != ''") > Done Done http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@95 PS12, Line 95: "select * from functional.alltypes where string_col !=''") > Done Now it needs a space after '!='. -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 15 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:35:18 +0000 Gerrit-HasComments: Yes
