Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/19181/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19181/14//COMMIT_MSG@86 PS14, Line 86: xlarge, > It might be informational to add a column showing the cache overhead in byt Added data about the used cache size for each tpch query. http://gerrit.cloudera.org:8080/#/c/19181/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19181/15//COMMIT_MSG@17 PS15, Line 17: singleto > typo: singleton Done http://gerrit.cloudera.org:8080/#/c/19181/15/be/src/codegen/llvm-codegen-cache.h File be/src/codegen/llvm-codegen-cache.h: http://gerrit.cloudera.org:8080/#/c/19181/15/be/src/codegen/llvm-codegen-cache.h@106 PS15, Line 106: static constexpr size_t OptimalKeySize = sizeof(HashCode) + sizeof(ElementLengthType); > nit: this could be a (compile-time) constexpr. Done http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py File tests/custom_cluster/test_codegen_cache.py: http://gerrit.cloudera.org:8080/#/c/19181/12/tests/custom_cluster/test_codegen_cache.py@95 PS12, Line 95: "select * from functional.alltypes where string_col != ''") > Now it needs a space after '!='. Done -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 16 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Sat, 03 Dec 2022 00:52:40 +0000 Gerrit-HasComments: Yes
