Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19177 )
Change subject: WIP IMPALA-11718: Improve support for Hive Generic UDFs ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19177/7/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java: http://gerrit.cloudera.org:8080/#/c/19177/7/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java@45 PS7, Line 45: public HiveJavaFunctionFactoryImpl(String localLibPath) Changing the ctor signature here will break https://github.infra.cloudera.com/CDH/hive/blob/cdw-master/impala/src/java/org/apache/hadoop/hive/impala/ImpalaRuntimeHelper.java#L165 (discovered during a separate Canary run). -- To view, visit http://gerrit.cloudera.org:8080/19177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d402784fa91d1256f5d57fa16ac49728447c8 Gerrit-Change-Number: 19177 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Sat, 25 Feb 2023 13:06:28 +0000 Gerrit-HasComments: Yes
