Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 )
Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ...................................................................... Patch Set 1: Code-Review+1 (4 comments) LGTM, marked some nits. http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@10 PS1, Line 10: s nit: past tense http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@10 PS1, Line 10: is nit: past tense, plural http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@15 PS1, Line 15: g nit: typo http://gerrit.cloudera.org:8080/#/c/19328/1/be/src/exec/parquet/parquet-column-readers.h File be/src/exec/parquet/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/19328/1/be/src/exec/parquet/parquet-column-readers.h@426 PS1, Line 426: g nit: typo -- To view, visit http://gerrit.cloudera.org:8080/19328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ef37a1aa731eb54930d6689621cd6169fed6605 Gerrit-Change-Number: 19328 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 07 Dec 2022 17:08:02 +0000 Gerrit-HasComments: Yes
