Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 )
Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ...................................................................... Patch Set 2: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@10 PS1, Line 10: e > nit: past tense Done http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@10 PS1, Line 10: w > nit: past tense, plural I put it into paste tense, but I think it's singular as it is attached to "page filtering". http://gerrit.cloudera.org:8080/#/c/19328/1//COMMIT_MSG@15 PS1, Line 15: > nit: typo Done http://gerrit.cloudera.org:8080/#/c/19328/1/be/src/exec/parquet/parquet-column-readers.h File be/src/exec/parquet/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/19328/1/be/src/exec/parquet/parquet-column-readers.h@426 PS1, Line 426: > nit: typo Done -- To view, visit http://gerrit.cloudera.org:8080/19328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ef37a1aa731eb54930d6689621cd6169fed6605 Gerrit-Change-Number: 19328 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Dec 2022 17:37:37 +0000 Gerrit-HasComments: Yes
