Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 )
Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality ...................................................................... Patch Set 1: (2 comments) I read through quickly http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@110 PS1, Line 110: * - > line has trailing whitespace Nit: delete line http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@129 PS1, Line 129: if (cardinality_ != -1) { Can cardinality_ be -1? In HdfsScanNode it can be but here maybe it cannot. -- To view, visit http://gerrit.cloudera.org:8080/19354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927c58c4adfd0ba1e135b63454ac9b07991cbf Gerrit-Change-Number: 19354 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 14 Dec 2022 01:24:21 +0000 Gerrit-HasComments: Yes
