Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 )
Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Great fix, LGTM! http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@105 PS1, Line 105: cardinalities nit: singular http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@196 PS1, Line 196: ctx_.getNextNodeId(), tblRef_, conjuncts_, aggInfo_, dataFilesWithoutDeletes_, nit: indentation http://gerrit.cloudera.org:8080/#/c/19354/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@227 PS1, Line 227: dataScanNodeId, tblRef_, conjuncts_, aggInfo_, dataFilesWithDeletes_, nit: indentation -- To view, visit http://gerrit.cloudera.org:8080/19354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927c58c4adfd0ba1e135b63454ac9b07991cbf Gerrit-Change-Number: 19354 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 14 Dec 2022 09:50:07 +0000 Gerrit-HasComments: Yes
