Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 )
Change subject: IMPALA-11375 Impala shell outputs details of each RPC ...................................................................... Patch Set 5: (108 comments) http://gerrit.cloudera.org:8080/#/c/19388/5/bin/impala-shell.sh File bin/impala-shell.sh: http://gerrit.cloudera.org:8080/#/c/19388/5/bin/impala-shell.sh@57 PS5, Line 57: echo "impala python shell waiting for remote debugging connection on port ${IMPALA_SHELL_DEBUG_PORT}" line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@684 PS5, Line 684: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@810 PS5, Line 810: o flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@820 PS5, Line 820: y flake8: E501 line too long (106 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@840 PS5, Line 840: = flake8: E711 comparison to None should be 'if cond is None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@884 PS5, Line 884: e flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@934 PS5, Line 934: n flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@975 PS5, Line 975: r flake8: E501 line too long (107 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@987 PS5, Line 987: ) flake8: E501 line too long (113 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1002 PS5, Line 1002: t flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1021 PS5, Line 1021: T flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1067 PS5, Line 1067: e flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1181 PS5, Line 1181: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1185 PS5, Line 1185: - flake8: E501 line too long (118 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1187 PS5, Line 1187: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1193 PS5, Line 1193: - flake8: E501 line too long (118 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1210 PS5, Line 1210: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1215 PS5, Line 1215: - flake8: E501 line too long (118 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1217 PS5, Line 1217: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1220 PS5, Line 1220: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1223 PS5, Line 1223: - flake8: E501 line too long (118 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/shell/impala_client.py@1545 PS5, Line 1545: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py File shell/thrift_printer.py: http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@23 PS5, Line 23: class ThriftPrettyPrinter(object): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@38 PS5, Line 38: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@40 PS5, Line 40: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@41 PS5, Line 41: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@128 PS5, Line 128: ! flake8: E711 comparison to None should be 'if cond is not None:' http://gerrit.cloudera.org:8080/#/c/19388/5/shell/thrift_printer.py@130 PS5, Line 130: = flake8: E711 comparison to None should be 'if cond is None:' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1424 PS5, Line 1424: e flake8: E501 line too long (111 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1425 PS5, Line 1425: \ flake8: E501 line too long (130 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\[' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1429 PS5, Line 1429: \ flake8: W605 invalid escape sequence '\]' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1432 PS5, Line 1432: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1433 PS5, Line 1433: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1434 PS5, Line 1434: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1437 PS5, Line 1437: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1437 PS5, Line 1437: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\[' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1446 PS5, Line 1446: \ flake8: W605 invalid escape sequence '\]' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1449 PS5, Line 1449: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1449 PS5, Line 1449: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1450 PS5, Line 1450: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1453 PS5, Line 1453: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1453 PS5, Line 1453: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1456 PS5, Line 1456: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1456 PS5, Line 1456: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1457 PS5, Line 1457: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1457 PS5, Line 1457: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1458 PS5, Line 1458: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1458 PS5, Line 1458: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1459 PS5, Line 1459: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1460 PS5, Line 1460: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1460 PS5, Line 1460: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1461 PS5, Line 1461: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1461 PS5, Line 1461: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1462 PS5, Line 1462: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1462 PS5, Line 1462: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1463 PS5, Line 1463: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1463 PS5, Line 1463: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1464 PS5, Line 1464: \ flake8: W605 invalid escape sequence '\<' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1464 PS5, Line 1464: \ flake8: W605 invalid escape sequence '\>' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\[' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1470 PS5, Line 1470: \ flake8: W605 invalid escape sequence '\]' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1473 PS5, Line 1473: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1474 PS5, Line 1474: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\[' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\.' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1479 PS5, Line 1479: \ flake8: W605 invalid escape sequence '\]' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1482 PS5, Line 1482: \ flake8: W605 invalid escape sequence '\*' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1482 PS5, Line 1482: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/19388/5/tests/shell/test_shell_commandline.py@1483 PS5, Line 1483: \ flake8: W605 invalid escape sequence '\*' -- To view, visit http://gerrit.cloudera.org:8080/19388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36f8dbc96726aa2a573133acbe8a558299381f8b Gerrit-Change-Number: 19388 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 20:35:52 +0000 Gerrit-HasComments: Yes
