Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19388 )

Change subject: IMPALA-11375 Impala shell outputs details of each RPC
......................................................................


Patch Set 8:

(80 comments)

http://gerrit.cloudera.org:8080/#/c/19388/8/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/19388/8/shell/impala_client.py@1013
PS8, Line 1013: r
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/19388/8/shell/impala_client.py@1206
PS8, Line 1206: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\['


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\.'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1433
PS8, Line 1433: \
flake8: W605 invalid escape sequence '\]'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1436
PS8, Line 1436: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1437
PS8, Line 1437: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1438
PS8, Line 1438: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1441
PS8, Line 1441: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1441
PS8, Line 1441: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\['


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\.'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1450
PS8, Line 1450: \
flake8: W605 invalid escape sequence '\]'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1453
PS8, Line 1453: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1453
PS8, Line 1453: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1454
PS8, Line 1454: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1457
PS8, Line 1457: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1457
PS8, Line 1457: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1460
PS8, Line 1460: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1460
PS8, Line 1460: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1461
PS8, Line 1461: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1461
PS8, Line 1461: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1462
PS8, Line 1462: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1462
PS8, Line 1462: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1463
PS8, Line 1463: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1464
PS8, Line 1464: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1464
PS8, Line 1464: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1465
PS8, Line 1465: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1465
PS8, Line 1465: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1466
PS8, Line 1466: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1466
PS8, Line 1466: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1467
PS8, Line 1467: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1467
PS8, Line 1467: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1468
PS8, Line 1468: \
flake8: W605 invalid escape sequence '\<'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1468
PS8, Line 1468: \
flake8: W605 invalid escape sequence '\>'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\['


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\.'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1474
PS8, Line 1474: \
flake8: W605 invalid escape sequence '\]'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1477
PS8, Line 1477: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1478
PS8, Line 1478: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\['


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\.'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1483
PS8, Line 1483: \
flake8: W605 invalid escape sequence '\]'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1486
PS8, Line 1486: \
flake8: W605 invalid escape sequence '\*'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1486
PS8, Line 1486: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/19388/8/tests/shell/test_shell_commandline.py@1487
PS8, Line 1487: \
flake8: W605 invalid escape sequence '\*'



--
To view, visit http://gerrit.cloudera.org:8080/19388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36f8dbc96726aa2a573133acbe8a558299381f8b
Gerrit-Change-Number: 19388
Gerrit-PatchSet: 8
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jan 2023 23:34:27 +0000
Gerrit-HasComments: Yes

Reply via email to