Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19140 )
Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for find_next_compact2 method ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py@27 PS2, Line 27: from hive_metastore.ttypes import SerDeInfo > nit: move this to line 21 to keep the import list sorted Ack http://gerrit.cloudera.org:8080/#/c/19140/2/tests/custom_cluster/test_metastore_service.py@1005 PS2, Line 1005: compactRequest.workerId = "myworker" > Should we verify the result? I don't think that is required. This is a dummy call, I don't know what exactly I need to verify in the result. Also, since there are no delta files for compaction, it'll be empty compaction. The purpose of this test is to verify if a particular API in HMS is reachable or not. -- To view, visit http://gerrit.cloudera.org:8080/19140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761 Gerrit-Change-Number: 19140 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <hsnuso...@gmail.com> Gerrit-Comment-Date: Tue, 10 Jan 2023 00:10:04 +0000 Gerrit-HasComments: Yes
