Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19140 )

Change subject: IMPALA-11661: Added new api in MetastoreServiceHandler for 
find_next_compact2 method
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

LGTM. I can bump to +2 after the comments are addressed.

http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:

http://gerrit.cloudera.org:8080/#/c/19140/4/tests/custom_cluster/test_metastore_service.py@1009
PS4, Line 1009:         finally:
nit: we'd better drop the table at the end.



--
To view, visit http://gerrit.cloudera.org:8080/19140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1663c16d2649c9c455e6dffde02894819b2761
Gerrit-Change-Number: 19140
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hsnuso...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 01:03:18 +0000
Gerrit-HasComments: Yes

Reply via email to