Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 )
Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@768 PS1, Line 768: // HMS will override 'external.table.purge' to 'TRUE' When 'iceberg.catalog' is not : // the Hive Catalog for managed tables. > Sure! I should create a Jira in the Hive community, right? Yeah, I just tested the following in Hive: create table test_parq_hive (i int) stored as parquet tblproperties ('external.table.purge'='false'); Then checked the table properties via the DESCRIBE FORMATTED command: ... external.table.purge | TRUE ... I think it's worth to raise a Jira for this. -- To view, visit http://gerrit.cloudera.org:8080/19416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2649dd38fbe050044817d6c425ef447245aa2829 Gerrit-Change-Number: 19416 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jan 2023 14:37:08 +0000 Gerrit-HasComments: Yes
