lipeng...@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 )
Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables ...................................................................... Patch Set 2: (1 comment) https://issues.apache.org/jira/browse/HIVE-26959?focusedCommentId=17678103&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17678103 It seems that we can only warn users that the property 'external.table.purge' will be ignored when creating an Iceberg table if the catalog is not the Hive Catalog, because without external keyword Hive will consider like we are trying for managed table, which will set 'external.table.purge' to TRUE. At least, if we warn the user and they won't be confused by explicitly set 'external.table.purge' to FALSE but it is really TRUE. http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/19416/1/fe/src/main/java/org/apache/impala/catalog/Table.java@191 PS1, Line 191: TRUE > What is the reason behind setting the default to true for external tables? https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ExternalTables Since Hive 4.0.0, this is set to true by default, but if we don't want to drop the data when dropping the table, we should set it to false when creating the table or with the 'alter table' statement. -- To view, visit http://gerrit.cloudera.org:8080/19416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2649dd38fbe050044817d6c425ef447245aa2829 Gerrit-Change-Number: 19416 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 28 Jan 2023 07:03:52 +0000 Gerrit-HasComments: Yes
