Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19431 )
Change subject: IMPALA-11846: Fix builds with setuptools>=66.0.0 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19431/2/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19431/2/shell/CMakeLists.txt@29 PS2, Line 29: 1.0.0.dev The Impala-shell version currently released on PyPI is 4.2.0. Would it be possible to set this version number based on that value? Also (if that's not too much for a quick fix) it would be nicer to drive this value off of a CMake variable (or similar) to ensure coherency between the two affected lines. This is not a strong request; I think it would also be fine to do it in the context of the follow-up ticket you mentioned. -- To view, visit http://gerrit.cloudera.org:8080/19431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eb0957fb576e590b86b6fe570216cfb72d11aef Gerrit-Change-Number: 19431 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 16:13:11 +0000 Gerrit-HasComments: Yes
