Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19431 )
Change subject: IMPALA-11846: Fix builds with setuptools>=66.0.0 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19431/2/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19431/2/shell/CMakeLists.txt@29 PS2, Line 29: 1.0.0.dev > The Impala-shell version currently released on PyPI is 4.2.0. We could do 4.3.0 so we test is for the next release. I am no Cmake expert, tried it for a while but gave up for now and added the idea to the followup jira already. shell/make_shell_tarball.sh generates the impala_build_version.py, which can be used, or shell/packaging/setup.py writes the used version to the staging directory in version.txt. The thing is, both are generated during build time and we would need to guarantee to execute those targets before creating the full path of the package. Other possibility could be to use wildcards, but not sure if that's better, the cmake config already isnt great for this part, the generated test package or its name got stuck somewhere and could not generate a new one with the new BUILD_VERSION only after git clean -dfx -- To view, visit http://gerrit.cloudera.org:8080/19431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eb0957fb576e590b86b6fe570216cfb72d11aef Gerrit-Change-Number: 19431 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 16:25:21 +0000 Gerrit-HasComments: Yes
