Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 )
Change subject: IMPALA-9551: Allow mixed complex types in select list ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/19322/12/be/src/runtime/complex-value-writer.h File be/src/runtime/complex-value-writer.h: http://gerrit.cloudera.org:8080/#/c/19322/12/be/src/runtime/complex-value-writer.h@48 PS12, Line 48: // 'column_type' to figure out field names and types. This function can call itself The 'column_type' argument was removed, so this comment no longer seems appropriate. http://gerrit.cloudera.org:8080/#/c/19322/12/be/src/runtime/complex-value-writer.inline.h File be/src/runtime/complex-value-writer.inline.h: http://gerrit.cloudera.org:8080/#/c/19322/12/be/src/runtime/complex-value-writer.inline.h@226 PS12, Line 226: // Gets a StructVal and writes it in JSON format using 'writer'. Uses 'column_type' to 'column_type' doesn't exist anymore. http://gerrit.cloudera.org:8080/#/c/19322/12/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/19322/12/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@404 PS12, Line 404: if (childColExprSlotRef.getType().isStructType()) { It seems strange to handle struct types here, but collection types down in putOneStructMemberIntoSmaps. http://gerrit.cloudera.org:8080/#/c/19322/12/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/19322/12/tests/query_test/test_nested_types.py@185 PS12, Line 185: if vector.get_value('exec_option')['disable_codegen'] == 'False': Why are we skipping when codegen is disabled? http://gerrit.cloudera.org:8080/#/c/19322/12/tests/query_test/test_nested_types.py@213 PS12, Line 213: if vector.get_value('exec_option')['disable_codegen'] == 'False': Why are we skipping when codegen is disabled? -- To view, visit http://gerrit.cloudera.org:8080/19322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I476d98884b5fd192dfcd4feeec7947526aebe993 Gerrit-Change-Number: 19322 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Jan 2023 23:04:28 +0000 Gerrit-HasComments: Yes
