Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 )
Change subject: IMPALA-9551: Allow mixed complex types in select list ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/19322/14/be/src/runtime/complex-value-writer.inline.h File be/src/runtime/complex-value-writer.inline.h: http://gerrit.cloudera.org:8080/#/c/19322/14/be/src/runtime/complex-value-writer.inline.h@120 PS14, Line 120: CollectionValueToJSON(*nested_collection_val, child_slot_desc.type().type, child_slot_desc.type() could be replaced with child_type http://gerrit.cloudera.org:8080/#/c/19322/14/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/19322/14/be/src/runtime/descriptors.cc@364 PS14, Line 364: TupleDescriptor* target_tuple = this; This common part could be extracted from the conditions http://gerrit.cloudera.org:8080/#/c/19322/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/19322/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@408 PS14, Line 408: static private void verifySameChild(Path childSlotDescPath, Path childColExprPath, The access modifier should precede the static modifier -- To view, visit http://gerrit.cloudera.org:8080/19322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I476d98884b5fd192dfcd4feeec7947526aebe993 Gerrit-Change-Number: 19322 Gerrit-PatchSet: 14 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 30 Jan 2023 12:18:23 +0000 Gerrit-HasComments: Yes
