Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 29: Sorry to see this being pending for so long.. I think cloning the range partitions is a futher feature and we can do it in a separate patch. Note that CreateTableLike for HDFS tables doesn't clone the partitions. Range partitions in Kudu tables are similar to the partitions in HDFS tables. I think it's ok to not clone them, or provide users the ability to choose the behavior. On the other side, cloning all the range partitions of a large kudu table might take a long time. Users might just want to create a tiny table for testing. I suggest spill over the support of cloning range partitions into a separate patch, and let this patch focus on only cloning the schema (including hash partitions). In the follow-on patch, we can add query option or new syntax for cloning range partitions as well. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 29 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 02:02:23 +0000 Gerrit-HasComments: No