Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/32/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3930 PS32, Line 3930: createTableParams.setPrimary_key_column_names(kuduTable.getPrimaryKeyColumnNames()); : List<TColumn> columns = new ArrayList<>(); : for (Column col : kuduTable.getColumns()) { : columns.add(col.toThrift()); : } IMPALA-11809 was merged recently, which added support for non unique primary key. If the source table has non unique primary key, auto_incrementing_id column was added when the source table was created. auto_incrementing_id column must be skipped when cloning a new Kudu table, otherwise Kudu will throw exception. If you think it's too complicated, I can fix it in a follow on patch. -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 32 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Tue, 14 Feb 2023 06:11:20 +0000 Gerrit-HasComments: Yes