pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 )
Change subject: IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT_DOP>1 ...................................................................... Patch Set 3: (4 comments) > Patch Set 2: > > (4 comments) http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@7 PS2, Line 7: Impalad hit DCHECK when running union on : empty table with MT_DOP>1 > nit: we'd better summarize how the issue is fixed instead of describing the I've updated the description, should I change the title of the jira as well? http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@11 PS2, Line 11: w > nit: no space at line start Done http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py File tests/custom_cluster/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py@68 PS2, Line 68: @CustomClusterTestSuite.with_args(cluster_size=1) > Please verify the test failed without the fix. I think it won't fail since Done http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py@73 PS2, Line 73: self.client.execute("select count(*) from (select f2 from" : " functional.emptytable union all select id from" : " functional.alltypestiny) t") : > We can use an existing table (e.g. functional.alltypestiny) instead of crea Done -- To view, visit http://gerrit.cloudera.org:8080/19474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbae5e1a78211327a214b2d936743bda767ae3c4 Gerrit-Change-Number: 19474 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 08 Feb 2023 06:01:47 +0000 Gerrit-HasComments: Yes
