Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 )
Change subject: IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT_DOP>1 ...................................................................... Patch Set 3: (4 comments) Thanks for fixing this. http://gerrit.cloudera.org:8080/#/c/19474/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19474/3//COMMIT_MSG@12 PS3, Line 12: returned the Nit: returned from the computeNodeResourceProfile() function http://gerrit.cloudera.org:8080/#/c/19474/3//COMMIT_MSG@12 PS3, Line 12: Nit: unnecessary leading space here and in the following lines. http://gerrit.cloudera.org:8080/#/c/19474/3//COMMIT_MSG@16 PS3, Line 16: fix is also verified with an end-to-end test. Could mention that the added test is in test_mt_dop.py. http://gerrit.cloudera.org:8080/#/c/19474/3/tests/custom_cluster/test_mt_dop.py File tests/custom_cluster/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/19474/3/tests/custom_cluster/test_mt_dop.py@70 PS3, Line 70: """ When used in DEBUG build, impalad crashed while running union on We could include the Jira number here (IMPALA-11803) as a reference. The comment could for example begin with "Regression test for IMPALA-11803" -- To view, visit http://gerrit.cloudera.org:8080/19474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbae5e1a78211327a214b2d936743bda767ae3c4 Gerrit-Change-Number: 19474 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 23 Feb 2023 10:49:13 +0000 Gerrit-HasComments: Yes
