Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19496 )
Change subject: IMPALA-11920: Support spill to HDFS address by service name ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19496/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19496/1/be/src/runtime/tmp-file-mgr.cc@825 PS1, Line 825: Substitute("The scratch URI must have a path or port number: '$0'", raw_path_)); There is one potentially ambiguous case here. If you wanted to put scratch-dirs in the HDFS root for some reason, then hdfs://hdfs1:100 could mean that you want to use port 100, or bytes_limit 100. Right now it will always be read as a port, as I think normal practice should be to put the scratch space in a directory; in Ozone you must use a volume. If you want to differentiate, add a trailing slash to the URI hdfs://hdfs1/:100 -- To view, visit http://gerrit.cloudera.org:8080/19496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167 Gerrit-Change-Number: 19496 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 13 Feb 2023 19:44:42 +0000 Gerrit-HasComments: Yes
