Hello Yida Wu, Shajini Thayasingh, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19496 to look at the new patch set (#4). Change subject: IMPALA-11920: Support spill to HDFS address by service ID ...................................................................... IMPALA-11920: Support spill to HDFS address by service ID Allows addressing HDFS (and Ozone) filesystems in `scratch_dirs` by a service identifier that doesn't include a port number. Examples - "hdfs://hdfs1/:10G" uses the root directory of HDFS with a 10G limit - "ofs://ozone1/tmp::" uses /tmp in Ozone with default limit/priority Updates `scratch_dirs` parsing to allow whitespace after each specifier, as in "hfs://hdfs1/ , /tmp". This is unambiguous and avoids failures for simple mistakes. Updates documentation to include examples with service identifier. Also fixes inconsistent use of ASCII quotes for example text, highlighting code and variable names, and normalizes descriptions between S3/HDFS/Ozone. Removes "priority" from remote descriptions as it is optional and does nothing. Testing: - new backend test cases run with HDFS and Ozone - manually tested that Impala starts with --impalad_args=--scratch_dirs=ofs://localhost/tmp,/tmp creates impala-scratch in both locations Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167 --- M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M docs/topics/impala_disk_space.xml 3 files changed, 153 insertions(+), 91 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/19496/4 -- To view, visit http://gerrit.cloudera.org:8080/19496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167 Gerrit-Change-Number: 19496 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>