Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19494 )
Change subject: IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Awesome work, Penglin! Thank you so much? http://gerrit.cloudera.org:8080/#/c/19494/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19494/2//COMMIT_MSG@31 PS2, Line 31: ArithmeticExpr(ADD) Nice! This plan is much better than the one that I proposed in the description! http://gerrit.cloudera.org:8080/#/c/19494/2//COMMIT_MSG@44 PS2, Line 44: Testing: Could you please add a planner test for select count(*) from iceberg_v2_positional_not_all_data_files_have_delete_files; -- To view, visit http://gerrit.cloudera.org:8080/19494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8172c805121bf91d23fe063f806493afe2f03d41 Gerrit-Change-Number: 19494 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Feb 2023 16:21:05 +0000 Gerrit-HasComments: Yes
