Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19494 )
Change subject: IMPALA-11802: Optimize count(*) queries for Iceberg V2 position delete tables ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Could you please add a few time-travel queries with count(*)? I think we don't have that currently for V2 tables. Would be nice to have both planner-tests and e2e-tests for it. Otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/19494/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19494/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@179 PS5, Line 179: ctx_.getQueryCtx().isOptimize_count_star_for_iceberg_v2() Please add comment that explains that if this method returns true, then it means we dont need dataFilesWithoutDeletes_ as we are optimizing count(*), and number of rows are added via an ArithmeticExpr. -- To view, visit http://gerrit.cloudera.org:8080/19494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8172c805121bf91d23fe063f806493afe2f03d41 Gerrit-Change-Number: 19494 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Feb 2023 17:11:41 +0000 Gerrit-HasComments: Yes
