Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/19508/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/19508/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2418 PS1, Line 2418: .add_write_notification_log_in_batch(batchRequest); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1012 PS1, Line 1012: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013 PS1, Line 1013: t flake8: E999 SyntaxError: invalid syntax http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013 PS1, Line 1013: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1013 PS1, Line 1013: WriteNotificationLogBatchRequest rqst = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014 PS1, Line 1014: n flake8: E113 unexpected indentation http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014 PS1, Line 1014: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1014 PS1, Line 1014: new WriteNotificationLogBatchRequest("hive", "default", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19508/1/tests/custom_cluster/test_metastore_service.py@1015 PS1, Line 1015: ; flake8: E703 statement ends with a semicolon -- To view, visit http://gerrit.cloudera.org:8080/19508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194 Gerrit-Change-Number: 19508 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 16 Feb 2023 21:25:36 +0000 Gerrit-HasComments: Yes