Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG@9 PS3, Line 9: In the MetastoreServiceHandler class, the 'add_write_notification_log_in_batch' We use a line length limit of 72 columns in the commit message. http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2415 PS3, Line 2415: Indentation in case of line continuation should be 4. http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@988 PS3, Line 988: reachable from impala (so that MetastoreServiceHandler in impala Nit: some of this line fits on the previous line (max line length is 90). http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@1017 PS3, Line 1017: # The HMS api add_write_notification_log_in_batch is reachable. Could also start this line with "If the above call is successful", like in the other test. -- To view, visit http://gerrit.cloudera.org:8080/19508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194 Gerrit-Change-Number: 19508 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 23 Feb 2023 16:24:01 +0000 Gerrit-HasComments: Yes
