Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 )
Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness ...................................................................... Patch Set 3: (1 comment) Thanks for this patch, LGTM! It could be a bit shorter, I don't have any preference, so this version works for me as well :). http://gerrit.cloudera.org:8080/#/c/19524/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/19524/3/tests/webserver/test_web_pages.py@498 PS3, Line 498: response_json['completed_queries']: nit: this would make a longer line but with one less loop (on our end :) ) zip(response_json['completed_queries'], response_json['in_flight_queries']) -- To view, visit http://gerrit.cloudera.org:8080/19524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d430a871415a3884dece772b8d8105c583c05 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 3 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Tue, 21 Feb 2023 13:16:03 +0000 Gerrit-HasComments: Yes