Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 )
Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@7 PS5, Line 7: is Nit: no need for 'is'. http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@9 PS5, Line 9: someimes Nit: sometimes. http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@10 PS5, Line 10: filters out duplicates I'm not sure it is easily understandable. Is the situation that the query is executed twice and one of them is in the 'in_flight' state, the other in 'completed' but the second one is filtered out? Could you clarify it? http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@11 PS5, Line 11: outputing Nit: outputting. http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@13 PS5, Line 13: exection Nit: execution? Also, do we know why the execution was duplicated in the first place? Was it a bug? http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@14 PS5, Line 14: response to ease debugging in the future. Can you clarify how the flakiness is fixed? Is it by also searching in response_json['in_flight_queries']? -- To view, visit http://gerrit.cloudera.org:8080/19524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d430a871415a3884dece772b8d8105c583c05 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 22 Feb 2023 14:41:35 +0000 Gerrit-HasComments: Yes
