Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 )
Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt flakiness ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@10 PS5, Line 10: filters out duplicates > I'm not sure I understand what "filters out duplicates" refers to. How is i I used the phrasing from the comments around the related native code, but it really is just noise in the context of this comment, so I removed it, maybe its easier to understand what I intended to do with this change: Related code in be/src/service/impala-http-handler.cc: Value completed_queries(kArrayType); { lock_guard<mutex> l(server_->query_log_lock_); for (const unique_ptr<ImpalaServer::QueryStateRecord>& log_entry : server_->query_log_) { // Don't show duplicated entries between in-flight and completed queries. if (in_flight_query_ids.find(log_entry->id) != in_flight_query_ids.end()) continue; Value record_json(kObjectType); QueryStateToJson(*log_entry, &record_json, document); completed_queries.PushBack(record_json, document->GetAllocator()); } } -- To view, visit http://gerrit.cloudera.org:8080/19524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d430a871415a3884dece772b8d8105c583c05 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Mon, 27 Feb 2023 12:46:59 +0000 Gerrit-HasComments: Yes
