Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 )
Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns ...................................................................... Patch Set 1: (3 comments) Thanks Csaba! I have some suggestion. http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@419 PS1, Line 419: * From the source 'longStats', set the low and high value for 'type' (one of the : * integer types). nit: Add mention to never call this function for TIMESTAMP column. http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@441 PS1, Line 441: default: As additional precaution, can we add TIMESTAMP case here, but silently ignore it or print WARN? http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@465 PS1, Line 465: default: Add case to silently ignore TIMESTAMP as well here. -- To view, visit http://gerrit.cloudera.org:8080/19548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If585d2543d49978140dcb7b8d49d6ea50e4a8544 Gerrit-Change-Number: 19548 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Feb 2023 15:59:37 +0000 Gerrit-HasComments: Yes
