Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 )
Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@586 PS2, Line 586: if (colType != Type.TIMESTAMP) { : // Low/high value handling is not yet implemented for timestamps. : setLowAndHighValue(colType.getPrimitiveType(), longStats); : } > I am not sure if I understand the comment correctly. Ah, you are right. TINYINT, SMALLINT, INT, and BIGINT switch case will fall here as well. In that case, is it OK to change the branch case to if (colType.getPrimitiveType() != TIMESTAMP) It confuse me because setLowAndHighValue switches check for the PrimitiveType, not the Type (colType). -- To view, visit http://gerrit.cloudera.org:8080/19548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If585d2543d49978140dcb7b8d49d6ea50e4a8544 Gerrit-Change-Number: 19548 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Feb 2023 15:58:51 +0000 Gerrit-HasComments: Yes
