Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19614 )
Change subject: IMPALA-10983: Wait more in wait_for_event_processing if there is progress ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py@63 PS1, Line 63: < Nit: On L57 we had the current id on the left hand side, it would be more consistent if we inverted this expression. http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py@87 PS1, Line 87: success Nit: we only get to use 'success' if it is true, otherwise an exception is thrown. This is not new in this patch, and if you prefer not to address this now it's ok for me. -- To view, visit http://gerrit.cloudera.org:8080/19614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676854f7df9aea5fa10fb6ecf6381195bc8fa4b8 Gerrit-Change-Number: 19614 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Mar 2023 15:07:49 +0000 Gerrit-HasComments: Yes
