Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19614 )
Change subject: IMPALA-10983: Wait more in wait_for_event_processing if there is progress ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py@63 PS1, Line 63: i > Nit: On L57 we had the current id on the left hand side, it would be more c done also replaced current_event_id with target_event_id event id as the two "current" ids looked confusing http://gerrit.cloudera.org:8080/#/c/19614/1/tests/util/event_processor_utils.py@87 PS1, Line 87: if isin > Nit: we only get to use 'success' if it is true, otherwise an exception is you are right, the return value of wait_for_event_processing is never used, removed it -- To view, visit http://gerrit.cloudera.org:8080/19614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676854f7df9aea5fa10fb6ecf6381195bc8fa4b8 Gerrit-Change-Number: 19614 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Mar 2023 15:54:59 +0000 Gerrit-HasComments: Yes
