Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19647 )

Change subject: IMPALA-12015: enable healthz endpoint in admissiond webui
......................................................................


Patch Set 1:

(1 comment)

quick question

http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/service/impala-http-handler.cc@213
PS1, Line 213:   if ((server_ != NULL && server_->IsHealthy()) ||
I assume this means that server_ is null in AdmissionD?
Can we use admission_controller_ instead of AdmissiondEnv::GetInstance() ?



--
To view, visit http://gerrit.cloudera.org:8080/19647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffb5ee7a00992d1bdba1deddf181ae38aa206140
Gerrit-Change-Number: 19647
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Mar 2023 18:03:07 +0000
Gerrit-HasComments: Yes

Reply via email to