Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19647 )
Change subject: IMPALA-12015: enable healthz endpoint in admissiond webui ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/scheduling/admissiond-env.h File be/src/scheduling/admissiond-env.h: http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/scheduling/admissiond-env.h@87 PS1, Line 87: std::atomic_bool service_started_{false}; AdmissiondEnv analogous to ExecEnv for impalads. But service_started_ is not defined in ExecEnv for impalads. Should we move it to AdmissionControlService ? http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/19647/1/be/src/service/impala-http-handler.cc@213 PS1, Line 213: NULL nit: nullptr -- To view, visit http://gerrit.cloudera.org:8080/19647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffb5ee7a00992d1bdba1deddf181ae38aa206140 Gerrit-Change-Number: 19647 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Mar 2023 18:34:22 +0000 Gerrit-HasComments: Yes
