18770832...@163.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 )
Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19621/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/19621/2/be/src/service/impala-server.h@1207 PS2, Line 1207: is owned by 'query_log_' > nit: Is it still true with changes in this patch? Thanks for your review! The pointer(shared_ptr) of QueryStateRecord is indeed owned by the 'query_log_', so I believe the comment is accurate. -- To view, visit http://gerrit.cloudera.org:8080/19621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1279558b0d0b2a3ba31a496c0acb84ac9d99f2f1 Gerrit-Change-Number: 19621 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <18770832...@163.com> Gerrit-Reviewer: Anonymous Coward <18770832...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 02:15:39 +0000 Gerrit-HasComments: Yes
