18770832...@163.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/19621 )
Change subject: IMPALA-11998: Fix potential invalid iterator issue in ImpalaServer::GetQueryRecord() ...................................................................... Patch Set 2: (3 comments) Thanks for your review. http://gerrit.cloudera.org:8080/#/c/19621/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19621/2//COMMIT_MSG@13 PS2, Line 13: if query_log_index_ just deletes the corresponding record > nit: if the corresponding record in query_log_index_ is just deleted Done http://gerrit.cloudera.org:8080/#/c/19621/2//COMMIT_MSG@16 PS2, Line 16: For > nit: To Done http://gerrit.cloudera.org:8080/#/c/19621/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/19621/2/be/src/service/impala-server.cc@759 PS2, Line 759: be earlier in the query log > retried query ran later than the original query, it should be closer to the Done -- To view, visit http://gerrit.cloudera.org:8080/19621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1279558b0d0b2a3ba31a496c0acb84ac9d99f2f1 Gerrit-Change-Number: 19621 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <18770832...@163.com> Gerrit-Reviewer: Anonymous Coward <18770832...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 07:01:13 +0000 Gerrit-HasComments: Yes
